fix(core): use v8 serializer in v19 #31222
Conversation
…void issues when JSON.stringify would fail fix(core): v8 serializer should be able to hash tasks feat(core): use v8 serializer for daemon messages by default
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Failed to publish a PR release of this pull request, triggered by @AgentEnder. |
|
View your CI Pipeline Execution ↗ for commit 862e973.
☁️ Nx Cloud last updated this comment at |
|
Failed to publish a PR release of this pull request, triggered by @Cammisuli. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-31222-862e973
To request a new release for this pull request, mention someone from the Nx team or the |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| // strings | ||
| (message.startsWith('"') && message.endsWith('"')) || | ||
| // numbers | ||
| /^[0-9]+(.?[0-9]+)?$/.test(message) |
There was a problem hiding this comment.
There's a bug in the regex pattern for detecting numbers. The current pattern /^[0-9]+(.?[0-9]+)?$/ uses .? which matches any character (not just a decimal point) followed by an optional quantifier.
To properly match decimal numbers, the pattern should be /^[0-9]+(\.[0-9]+)?$/ where \. explicitly matches a literal decimal point.
| /^[0-9]+(.?[0-9]+)?$/.test(message) | |
| /^[0-9]+(\.[0-9]+)?$/.test(message) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| `No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:` + | ||
| Object.keys(pending).map((t) => ` - ${t}`) |
There was a problem hiding this comment.
The error message is using Object.keys(pending) but pending is a Map, not a plain object. This will produce an empty array or incorrect keys in the error message. To properly list the pending transaction IDs, use Array.from(pending.keys()) instead:
`No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:` +
Array.from(pending.keys()).map((t) => ` - ${t}`)| `No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:` + | |
| Object.keys(pending).map((t) => ` - ${t}`) | |
| `No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:` + | |
| Array.from(pending.keys()).map((t) => ` - ${t}`) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
See #30516, this is a backport to 19.8.x